Zhuohao Lee has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42715 )
Change subject: util/mainboard/google/volteer: Add dptf.asl to the template ......................................................................
util/mainboard/google/volteer: Add dptf.asl to the template
The dptf.asl is needed when creating a new volteer variant, otherwise, it will make the variant build failed. The error could be found from this link: https://review.coreboot.org/c/coreboot/+/42709
BUG=b:158797761 TEST=Generate the Delbin correctly
Change-Id: Ib4059df9e08d6a1dba88f0299bb39c8c6ae406ae --- A util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42715/1
diff --git a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..189cafe --- /dev/null +++ b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptf.asl>
Hello build bot (Jenkins), Paul Fagerburg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42715
to look at the new patch set (#2).
Change subject: util/mainboard/google/volteer: Add dptf.asl to the template ......................................................................
util/mainboard/google/volteer: Add dptf.asl to the template
The dptf.asl is needed when creating a new volteer variant, otherwise, it will make the variant build failed. The error could be found from this link: https://review.coreboot.org/c/coreboot/+/42709
BUG=b:158797761 TEST=Generate the Delbin correctly
Signed-off-by: Zhuohao Lee zhuohao@chromium.org Change-Id: Ib4059df9e08d6a1dba88f0299bb39c8c6ae406ae --- A util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42715/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42715 )
Change subject: util/mainboard/google/volteer: Add dptf.asl to the template ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42715 )
Change subject: util/mainboard/google/volteer: Add dptf.asl to the template ......................................................................
util/mainboard/google/volteer: Add dptf.asl to the template
The dptf.asl is needed when creating a new volteer variant, otherwise, it will make the variant build failed. The error could be found from this link: https://review.coreboot.org/c/coreboot/+/42709
BUG=b:158797761 TEST=Generate the Delbin correctly
Signed-off-by: Zhuohao Lee zhuohao@chromium.org Change-Id: Ib4059df9e08d6a1dba88f0299bb39c8c6ae406ae Reviewed-on: https://review.coreboot.org/c/coreboot/+/42715 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- A util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved
diff --git a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..189cafe --- /dev/null +++ b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/dptf.asl>
-
Furquan Shaikh (Code Review) -
Paul Fagerburg (Code Review)
-
Zhuohao Lee (Code Review)