Attention is currently required from: Shelley Chen, Furquan Shaikh, Paul Menzel, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56788 )
Change subject: device/pci_device.c: Scan only one device for PCIe ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56788/comment/51c07311_b7f2b461 PS3, Line 11: A PCIe downstream port normally leads to a link with : only device 0 on it. As an optimization, scan only for : device 0 in that case.
Please reflow the text to match line length limit (72 chars).
Done
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/56788/comment/2080e08e_cf2248ed PS3, Line 1207: A PCIe Downstream Port normally leads to a Link with only Device : * 0 on it (PCIe spec r5.0, sec 7.3.1). As an optimization, scan : * only for Device 0 in that situation.
Please reflow the text.
Done
https://review.coreboot.org/c/coreboot/+/56788/comment/291fa4b5_d26d0a3d PS3, Line 1260: 0x07
MIN(max_devfn, 0x07), as the passed max_devfn might be smaller than 0x07.
Done
-
Jianjun Wang (Code Review)