Attention is currently required from: Kangheui Won, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59449 )
Change subject: amdfwtool: clean up psp fw parsing ......................................................................
Patch Set 2:
(3 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/59449/comment/01c99211_4953ac9e PS2, Line 109: }; Nit: Please add a blank line.
https://review.coreboot.org/c/coreboot/+/59449/comment/3e2e4b40_91ab9a32 PS2, Line 110: psp_dir_valid_entries Why not merge this table with amd_fw_ps_table? Similar thing can be done for amd_bios_table, if required in the future.
https://review.coreboot.org/c/coreboot/+/59449/comment/a26fd43f_2ade39bf PS2, Line 178: if (strcmp(fw_name, "PSPBTLDR_WL_FILE") == 0) { : if (!cb_config->have_whitelist) : fw_type = AMD_FW_SKIP; : } Now that you have fw_type, you can avoid strcmp and check against fw_type.
-
Karthik Ramasubramanian (Code Review)