Change in coreboot[master]: mb/google/volteer/var/voxel: disable AUX orientation swap

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Sheng-Liang Pan (Code Review)

10 Aug 2020 10 Aug '20

2:33 a.m.

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

mb/google/volteer/var/voxel: disable AUX orientation swap

fix C0 DP issue when cable is flipped.

BUG=b:162376062 BRANCH=master TEST=build and verify C0 can display out with cable flipped.

Signed-off-by: Pan Sheng-Liang sheng-liang.pan@quanta.corp-partner.google.com Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac --- M src/mainboard/google/volteer/variants/voxel/overridetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/44324/1

diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index 43296d5..ab75bcd 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -1,4 +1,8 @@ chip soc/intel/tigerlake + register "TcssAuxOri" = "0" + register "IomTypeCPortPadCfg[0]" = "0x09000000" + register "IomTypeCPortPadCfg[1]" = "0x09000000" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Sheng-Liang Pan (Code Review)

10 Aug 10 Aug

4:10 a.m.

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1: Code-Review+1

YH Lin (Code Review)

3:41 p.m.

YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 10 Aug 2020 15:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Brandon Breitenstein (Code Review)

9:43 p.m.

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1:

I'm going to push a patch that makes default as TcssAuxOri = 0 and add the overrides for the corresponding boards that need TcssAuxOri on port 0

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Brandon Breitenstein brandon.breitenstein@intel.com Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Gerrit-Comment-Date: Mon, 10 Aug 2020 21:43:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Brandon Breitenstein (Code Review)

10 p.m.

Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1:

updated devicetree patch posted here

https://review.coreboot.org/c/coreboot/+/44358

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Brandon Breitenstein brandon.breitenstein@intel.com Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Gerrit-Comment-Date: Mon, 10 Aug 2020 22:00:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Derek Huang (Code Review)

11 Aug 11 Aug

2:32 a.m.

Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1:

We don't need this if there is a patch to make default as TcssAuxOri =0

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Brandon Breitenstein brandon.breitenstein@intel.com Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Gerrit-Comment-Date: Tue, 11 Aug 2020 02:32:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

2:36 a.m.

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Patch Set 1: -Code-Review

...

Patch Set 1:

We don't need this if there is a patch to make default as TcssAuxOri =0

got it, I will abandon this CL after https://review.coreboot.org/c/coreboot/+/44358 merged.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Brandon Breitenstein brandon.breitenstein@intel.com Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Gerrit-Comment-Date: Tue, 11 Aug 2020 02:36:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Sheng-Liang Pan (Code Review)

18 Aug 18 Aug

2:12 a.m.

Sheng-Liang Pan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44324 )

Change subject: mb/google/volteer/var/voxel: disable AUX orientation swap ......................................................................

Abandoned

abandon due to https://review.coreboot.org/c/coreboot/+/44358 merged

-- To view, visit https://review.coreboot.org/c/coreboot/+/44324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5915ab127d4c3e34c91c4b8b1c5147ddfcf5deac Gerrit-Change-Number: 44324 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Derek Huang derek.huang@intel.corp-partner.google.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Gerrit-Reviewer: YH Lin yueherngl@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Brandon Breitenstein brandon.breitenstein@intel.com Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Utkarsh H Patel utkarsh.h.patel@intel.corp-partner.google.com Gerrit-MessageType: abandon

1591

days inactive

1599

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Brandon Breitenstein (Code Review)
Derek Huang (Code Review)
Sheng-Liang Pan (Code Review)
YH Lin (Code Review)