build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50895 )
Change subject: soc/intel/common: Add new IRQ module
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/50895/comment/e1f26cc0_f73fa311
PS1, Line 204: if (!is_valid_pin(constraints[i].pci_pin)) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/50895/comment/410783f1_868e560a
PS1, Line 231: printk(BIOS_ERR, "ERROR: %s: No free pins left for UNIQUE IRQ\n", __func__);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f22a0e2e4ef0cedcecd6bd6650f904994a8a620
Gerrit-Change-Number: 50895
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Feb 2021 01:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment