Attention is currently required from: Felix Held, Paul Menzel.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84382?usp=email )
Change subject: soc/amd/glinda: Update I2C for glinda ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84382/comment/432c7d51_6261628d?usp... : PS2, Line 7: soc/amd/glinda: Update I2C for glinda
Maybe: […]
That makes it sound like I reviewed the whole soc/amd/glinda code. Maybe if I write: `src/soc/amd/glinda/include/soc/i2c.h: Review and Update for glinda` ?
https://review.coreboot.org/c/coreboot/+/84382/comment/d4444d43_be650f49?usp... : PS2, Line 9: I24
I2C4
Done
https://review.coreboot.org/c/coreboot/+/84382/comment/873b2737_1e15221c?usp... : PS2, Line 10:
Mention that you reviewed the file, so the to-do is removed?
Done
File src/soc/amd/glinda/include/soc/smi.h:
https://review.coreboot.org/c/coreboot/+/84382/comment/0eed1f7d_ffa1c331?usp... : PS2, Line 117: #define SMITYPE_USB_PD_I2C4_INTR2 70
same here
Done