Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC fmap section ......................................................................
mb/amd/mandolin: resize EC fmap section
The EC firmware is 128k including its header, so there's no need to reserve another 4k for the header.
TEST=Mandolin still boots.
Change-Id: Id3a7a087bf37461ca8ad3da9a809f13d7f0d570c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/mandolin.fmd 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/42705/1
diff --git a/src/mainboard/amd/mandolin/mandolin.fmd b/src/mainboard/amd/mandolin/mandolin.fmd index c702ba9..382c030 100644 --- a/src/mainboard/amd/mandolin/mandolin.fmd +++ b/src/mainboard/amd/mandolin/mandolin.fmd @@ -1,7 +1,7 @@ FLASH@0xFF800000 0x800000 { BIOS@0x0 { - EC@0x0 0x21000 - RW_MRC_CACHE@0x21000 0x10000 + EC@0x0 0x20000 + RW_MRC_CACHE@0x20000 0x10000 FMAP 0x1000 COREBOOT(CBFS) }
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC fmap section ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC fmap section ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC fmap section ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG@7 PS1, Line 7: resize Using *Decrease size of EC FMAP section* or *Decrease EC FMAP section size* would be more specific.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42705
to look at the new patch set (#2).
Change subject: mb/amd/mandolin: resize EC FMAP section to match EC firmware size ......................................................................
mb/amd/mandolin: resize EC FMAP section to match EC firmware size
The EC firmware is 128k including its header, so there's no need to reserve another 4k for the header.
TEST=Mandolin still boots.
Change-Id: Id3a7a087bf37461ca8ad3da9a809f13d7f0d570c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/mandolin.fmd 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/42705/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC FMAP section to match EC firmware size ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG@7 PS1, Line 7: resize
Using *Decrease size of EC FMAP section* or *Decrease EC FMAP section size* would be more specific.
it's not that much about the decrease, but more about the partition to have the exact size of the ec firmware. the exact resize amount and the reason are two lines below in the commit message
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC FMAP section to match EC firmware size ......................................................................
mb/amd/mandolin: resize EC FMAP section to match EC firmware size
The EC firmware is 128k including its header, so there's no need to reserve another 4k for the header.
TEST=Mandolin still boots.
Change-Id: Id3a7a087bf37461ca8ad3da9a809f13d7f0d570c Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42705 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/mandolin.fmd 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/mandolin.fmd b/src/mainboard/amd/mandolin/mandolin.fmd index c702ba9..382c030 100644 --- a/src/mainboard/amd/mandolin/mandolin.fmd +++ b/src/mainboard/amd/mandolin/mandolin.fmd @@ -1,7 +1,7 @@ FLASH@0xFF800000 0x800000 { BIOS@0x0 { - EC@0x0 0x21000 - RW_MRC_CACHE@0x21000 0x10000 + EC@0x0 0x20000 + RW_MRC_CACHE@0x20000 0x10000 FMAP 0x1000 COREBOOT(CBFS) }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42705 )
Change subject: mb/amd/mandolin: resize EC FMAP section to match EC firmware size ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42705/1//COMMIT_MSG@7 PS1, Line 7: resize
it's not that much about the decrease, but more about the partition to have the exact size of the ec […]
Doesn’t help for `git log --oneline`.