Attention is currently required from: Raul Rangel, Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 )
Change subject: mb/google/skyrim: Add named GPIO's
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/666b72e5_33814a99
PS2, Line 10: SYS_RST_ODL
We may not be configuring the GPIOs in other places, but we are referencing them.
Yes, I am totally onboard using the netnames where we are referencing the GPIO_NN. That is what I meant by using netnames when configuring a hardware block eg. in devicetree, port_descriptors etc.
But while configuring the GPIO, I prefer to use GPIO_NN itself rather than netnames. Otherwise you have to introduce a whole new set of macros to make it work for newer and older SoCs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340
Gerrit-Change-Number: 74592
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 20 Apr 2023 23:33:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment