Attention is currently required from: Julius Werner, Martin L Roth, Patrick Georgi, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75879?usp=email )
Change subject: Docs/contrib/coding_style: Document the preference for if() vs #if
......................................................................
Patch Set 1:
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/75879/comment/1a5a8d6c_dcdfeecc :
PS1, Line 539: ifdef
Should we go further and say that #ifdef is just forbidden entirely? With the way CONFIG() works in […]
I would say no `#ifdef` in `.c` files. IIRC, `#ifdef __SIMPLE_DEVICE__`
was never meant to be used there either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75879?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I995e3765ce996d9a83efb34be6f905846357f981
Gerrit-Change-Number: 75879
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 22 Jun 2023 11:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment