Attention is currently required from: Andy Pont, Tim Wawrzynczak, Paul Menzel, Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS ......................................................................
Patch Set 24:
(3 comments)
File src/soc/intel/common/block/cse/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120619): https://review.coreboot.org/c/coreboot/+/52800/comment/af7cb164_b9eff732 PS24, Line 870: if (CONFIG(ME_STATE_BY_CMOS)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120619): https://review.coreboot.org/c/coreboot/+/52800/comment/d0dca0f0_ee806247 PS24, Line 901: if (CONFIG(ME_STATE_BY_CMOS)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120619): https://review.coreboot.org/c/coreboot/+/52800/comment/7dcbcd0c_d959611e PS24, Line 905: else suspect code indent for conditional statements (16, 8)
-
build bot (Jenkins) (Code Review)