build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58697 )
Change subject: cpu/x86/smm: Retype variables ......................................................................
Patch Set 2: Verified+1
(3 comments)
File src/cpu/x86/smm/smm_module_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139501): https://review.coreboot.org/c/coreboot/+/58697/comment/6ac6d5bf_ba285457 PS2, Line 325: uintptr_t base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139501): https://review.coreboot.org/c/coreboot/+/58697/comment/8a862d3c_ead9526b PS2, Line 325: uintptr_t base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139501): https://review.coreboot.org/c/coreboot/+/58697/comment/d80ecd74_0d1699d7 PS2, Line 491: int smm_load_module(const uintptr_t smram_base, const size_t smram_size, struct smm_loader_params *params) line over 96 characters