Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 8:
(10 comments)
Patchset:
PS8: sorry for the confusion created here; had to figure out things myself first
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/62903/comment/c755eb11_bf5d3b32 PS8, Line 12: 0 1
https://review.coreboot.org/c/coreboot/+/62903/comment/a1a31368_7e768a7a PS8, Line 13: 0 1
https://review.coreboot.org/c/coreboot/+/62903/comment/97e18a54_7b58837b PS8, Line 24: 1 0
https://review.coreboot.org/c/coreboot/+/62903/comment/99454e9b_a3c38eec PS8, Line 25: 1 0
https://review.coreboot.org/c/coreboot/+/62903/comment/162a75ec_2fea141a PS8, Line 38: .start_logical_lane = 2, : .end_logical_lane = 3, not sure if the numbers need to be swapped or not
https://review.coreboot.org/c/coreboot/+/62903/comment/f9608fa5_e0a4b28d PS8, Line 49: {/* unused MXM */ : .engine_type = UNUSED_ENGINE, : .port_present = false, : .start_logical_lane = 4, : .end_logical_lane = 7, : .device_number = 0, : .function_number = 0, : .link_speed_capability = GEN3, : .turn_off_unused_lanes = true, : }, : { /* unused MXM2 */ : .engine_type = UNUSED_ENGINE, : .port_present = false, : .start_logical_lane = 8, : .end_logical_lane = 11, : .device_number = 0, : .function_number = 0, : .link_speed_capability = GEN3, : .turn_off_unused_lanes = true, : }, : { /* unused MXM3 */ : .engine_type = UNUSED_ENGINE, : .port_present = false, : .start_logical_lane = 12, : .end_logical_lane = 15, : .device_number = 0, : .function_number = 0, : .link_speed_capability = GEN3, : .turn_off_unused_lanes = true, : }, : { /* unused SSD2 */ : .engine_type = UNUSED_ENGINE, : .port_present = false, : .start_logical_lane = 16, : .end_logical_lane = 19, : .device_number = 0, : .function_number = 0, : .link_speed_capability = GEN3, : .turn_off_unused_lanes = true, : }, can this be removed?
https://review.coreboot.org/c/coreboot/+/62903/comment/3a6003bd_3e38f297 PS8, Line 98: DDI_HDMI DDI_DP
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62903/comment/2d844b00_9f9f10cb PS8, Line 50: device ref gpp_bridge_0 on # WLAN : chip drivers/wifi/generic : register "wake" = "GEVENT_8" : device pci 00.0 on end : end : end : device ref gpp_bridge_1 on end # SD wifi before sd turned out to be the correct order after figuring out how the physical to logical lane numbering works on this soc
File src/mainboard/google/skyrim/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/62903/comment/b53cdfb5_ef613c36 PS8, Line 9: : #define SD_DEVFN PCIE_GPP_2_0_DEVFN : #define WLAN_DEVFN PCIE_GPP_2_1_DEVFN swap
-
Felix Held (Code Review)