Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31792
Change subject: mb/facebook/watson: Enable TPM 1.2 support ......................................................................
mb/facebook/watson: Enable TPM 1.2 support
Enable TPM 1.2 via Kconfig options and devicetree.
Change-Id: I394195b3117c8583b6b506d6ad4f5170d2f45f9f Signed-off-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M src/mainboard/facebook/watson/Kconfig M src/mainboard/facebook/watson/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/31792/1
diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig index 00bdbea..609b14a 100644 --- a/src/mainboard/facebook/watson/Kconfig +++ b/src/mainboard/facebook/watson/Kconfig @@ -9,6 +9,8 @@ select INTEGRATED_UART select SERIRQ_CONTINUOUS_MODE select MAINBOARD_USES_IFD_GBE_REGION + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1
config MAINBOARD_DIR string diff --git a/src/mainboard/facebook/watson/devicetree.cb b/src/mainboard/facebook/watson/devicetree.cb index 30d99c2..92fe9c3 100644 --- a/src/mainboard/facebook/watson/devicetree.cb +++ b/src/mainboard/facebook/watson/devicetree.cb @@ -7,7 +7,11 @@ device pci 14.0 on end # xHCI Controller device pci 19.0 on end # Gigabit LAN Controller device pci 1d.0 on end # EHCI Controller - device pci 1f.0 on end # LPC Bridge + device pci 1f.0 on # LPC Bridge + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end + end device pci 1f.2 on end # SATA Controller device pci 1f.3 on end # SMBus Controller device pci 1f.5 on end # SATA Controller
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31792 )
Change subject: mb/facebook/watson: Enable TPM 1.2 support ......................................................................
Patch Set 1: Code-Review+2
Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31792 )
Change subject: mb/facebook/watson: Enable TPM 1.2 support ......................................................................
mb/facebook/watson: Enable TPM 1.2 support
Enable TPM 1.2 via Kconfig options and devicetree.
Change-Id: I394195b3117c8583b6b506d6ad4f5170d2f45f9f Signed-off-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31792 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com --- M src/mainboard/facebook/watson/Kconfig M src/mainboard/facebook/watson/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
diff --git a/src/mainboard/facebook/watson/Kconfig b/src/mainboard/facebook/watson/Kconfig index 00bdbea..609b14a 100644 --- a/src/mainboard/facebook/watson/Kconfig +++ b/src/mainboard/facebook/watson/Kconfig @@ -9,6 +9,8 @@ select INTEGRATED_UART select SERIRQ_CONTINUOUS_MODE select MAINBOARD_USES_IFD_GBE_REGION + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1
config MAINBOARD_DIR string diff --git a/src/mainboard/facebook/watson/devicetree.cb b/src/mainboard/facebook/watson/devicetree.cb index 30d99c2..92fe9c3 100644 --- a/src/mainboard/facebook/watson/devicetree.cb +++ b/src/mainboard/facebook/watson/devicetree.cb @@ -7,7 +7,11 @@ device pci 14.0 on end # xHCI Controller device pci 19.0 on end # Gigabit LAN Controller device pci 1d.0 on end # EHCI Controller - device pci 1f.0 on end # LPC Bridge + device pci 1f.0 on # LPC Bridge + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end + end device pci 1f.2 on end # SATA Controller device pci 1f.3 on end # SMBus Controller device pci 1f.5 on end # SATA Controller
-
David Hendricks (Code Review) -
Philipp Deppenwiese (Code Review)