Change in ...coreboot[master]: qualcomm: qclib: Ensure interface table entry name is terminated

[Julius Werner (Code Review)]

Hello Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33375

to review the following change.

Change subject: qualcomm: qclib: Ensure interface table entry name is terminated
......................................................................

qualcomm: qclib: Ensure interface table entry name is terminated

This string is printed in dump_te_table() so we should make sure it's
properly null-terminated.

This fixes Coverity issue 1401305.

Change-Id: I45827f552c2d8a4e01b50a699ac88ee457043282
Signed-off-by: Julius Werner 
---
M src/soc/qualcomm/common/qclib.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/33375/1

diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c
index 73c5250..25512a9 100644
--- a/src/soc/qualcomm/common/qclib.c
+++ b/src/soc/qualcomm/common/qclib.c
@@ -41,7 +41,7 @@
    struct qclib_cb_if_table_entry *te =
    	&qclib_cb_if_table.te[qclib_cb_if_table.num_entries++];
    assert(qclib_cb_if_table.num_entries <= qclib_cb_if_table.max_entries);
-	strncpy(te->name, name, sizeof(te->name));
+	strncpy(te->name, name, sizeof(te->name) - 1);
    te->blob_address = (uintptr_t)base;
    te->size = size;
    te->blob_attributes = attrs;

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33375 )

Change subject: qualcomm: qclib: Ensure interface table entry name is terminated
......................................................................

Patch Set 1: Code-Review+1

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33375 )

Change subject: qualcomm: qclib: Ensure interface table entry name is terminated
......................................................................

Patch Set 1:

*ping*

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33375 )

Change subject: qualcomm: qclib: Ensure interface table entry name is terminated
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33375 )

Change subject: qualcomm: qclib: Ensure interface table entry name is terminated
......................................................................

qualcomm: qclib: Ensure interface table entry name is terminated

This string is printed in dump_te_table() so we should make sure it's
properly null-terminated.

This fixes Coverity issue 1401305.

Change-Id: I45827f552c2d8a4e01b50a699ac88ee457043282
Signed-off-by: Julius Werner 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33375
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Patrick Georgi 
---
M src/soc/qualcomm/common/qclib.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c
index 73c5250..25512a9 100644
--- a/src/soc/qualcomm/common/qclib.c
+++ b/src/soc/qualcomm/common/qclib.c
@@ -41,7 +41,7 @@
    struct qclib_cb_if_table_entry *te =
    	&qclib_cb_if_table.te[qclib_cb_if_table.num_entries++];
    assert(qclib_cb_if_table.num_entries <= qclib_cb_if_table.max_entries);
-	strncpy(te->name, name, sizeof(te->name));
+	strncpy(te->name, name, sizeof(te->name) - 1);
    te->blob_address = (uintptr_t)base;
    te->size = size;
    te->blob_attributes = attrs;