Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31978 )
Change subject: Move calls to quick_ram_check() before CBMEM init ......................................................................
Patch Set 4:
(1 comment)
google/rowan is a dead board, feel free to delete it if it causes trouble... but I'm also skeptical of the 4K number. I don't see how this patch could add anywhere close to that much. Maybe a sign that something unexpected is happening.
https://review.coreboot.org/#/c/31978/4/src/lib/ramtest.c File src/lib/ramtest.c:
https://review.coreboot.org/#/c/31978/4/src/lib/ramtest.c@22 PS4, Line 22: #else This code doesn't look ready to run on other architectures. On Arm we enable DRAM caches before initializing CBMEM, so this would do nothing. If we want to use this in generic code, we should either create an <arch/...> API for non-temporal read/write that all architectures can implement, or move this onto another API (we already have dcache_clean_invalidate_all() available everywhere, but that's probably a bit too big of a hammer... we could expand the dcache_clean_invalidate_by_mva() APIs from Arm onto other architectures).