Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77968?usp=email )
Change subject: treewide: Move list.h to commonlib
......................................................................
Patch Set 8:
(1 comment)
File payloads/libpayload/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/77968/comment/61f6d95b_6b2f5e04 :
PS8, Line 73: INCLUDES += -I$(coreboottop)/src/commonlib/include
Sorry for not noticing this earlier, but I think we also want this wrapped in `ifeq ($(CONFIG_LP_GPL),y)`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77968?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I16eb7b743fb1d36301f0eda563a62364e7a9cfec
Gerrit-Change-Number: 77968
Gerrit-PatchSet: 8
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sat, 17 Feb 2024 00:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment