Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/16328 )
Change subject: util/intelmetool: Add bootguard information dump support
......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/#/c/16328/20/util/intelmetool/intelmetool.c
File util/intelmetool/intelmetool.c:
Line 307: if(msr_bootguard(&bootguard, debug) < 0) {
coding style: space
and following
https://review.coreboot.org/#/c/16328/20/util/intelmetool/msr.c
File util/intelmetool/msr.c:
Line 27: static int fd_msr = 0;
pass fd as argument or open the file in rdmsr, no need to make it static.
you are not using it again, and you are closing the fd in rdmsr
Line 40: if (read(fd_msr, buf, 8) == 8) {
read(fd_msr, &msr, 8) == 8
Line 62: int msr_bootguard(uint64_t *msr, int debug) {
coding style: { to next line
Line 75: if(!debug) {
coding style: space
--
To view, visit
https://review.coreboot.org/16328
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeec8e20fa8efc35d7db4c6a84be1f118dccfc4a
Gerrit-PatchSet: 20
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathias Krause
minipli@googlemail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes