Riku Viitanen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85762?usp=email )
Change subject: mb/asrock/b75pro3-m/dt: Clean it up a bit ......................................................................
mb/asrock/b75pro3-m/dt: Clean it up a bit
Remove superfluous comments duplicating the device names. Also when nothing is inside the device entry, move the "end" statements to the first line.
Change-Id: I2d244619dc10ec465af19dbfb918b9c37e059586 Signed-off-by: Riku Viitanen riku.viitanen@protonmail.com --- M src/mainboard/asrock/b75pro3-m/devicetree.cb 1 file changed, 23 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/85762/1
diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index 1cf5015..e0ed2c5 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -56,52 +56,44 @@ { 1, 0, 6 } }"
- device ref xhci on # USB 3.0 Controller + device ref xhci on subsystemid 0x1849 0x1e31 end - device ref mei1 on # Management Engine Interface 1 + device ref mei1 on subsystemid 0x1849 0x1e3a end - device ref mei2 off # Management Engine Interface 2 - end - device ref me_ide_r off # Management Engine IDE-R - end - device ref me_kt off end # Management Engine KT - device ref gbe off # Intel Gigabit Ethernet - end - device ref ehci2 on # USB2 EHCI #2 + device ref mei2 off end + device ref me_ide_r off end + device ref me_kt off end + device ref gbe off end + device ref ehci2 on subsystemid 0x1849 0x1e2d end - device ref hda on # High Definition Audio controller + device ref hda on subsystemid 0x1849 0x8892 end - device ref pcie_rp1 on # PCIe Port #1 + device ref pcie_rp1 on subsystemid 0x1849 0x1e10 end - device ref pcie_rp2 off # PCIe Port #2 - end - device ref pcie_rp3 off # PCIe Port #3 - end - device ref pcie_rp4 off # PCIe Port #4 - end - device ref pcie_rp5 on # PCIe Port #5, ASMedia ASM1062 SATA Controller + device ref pcie_rp2 off end + device ref pcie_rp3 off end + device ref pcie_rp4 off end + device ref pcie_rp5 on # ASMedia ASM1062 SATA Controller subsystemid 0x1849 0x1e18 end - device ref pcie_rp6 on # PCIe Port #6, Realtek PCIe GbE Controller + device ref pcie_rp6 on # Realtek PCIe GbE Controller subsystemid 0x1849 0x1e1a device pci 00.0 on end end - device ref pcie_rp7 off # PCIe Port #7 - end - device ref pcie_rp8 off # PCIe Port #8 - end - device ref ehci1 on # USB2 EHCI #1 + device ref pcie_rp7 off end + device ref pcie_rp8 off end + device ref ehci1 on subsystemid 0x1849 0x1e26 end - device ref pci_bridge on # PCI bridge + device ref pci_bridge on subsystemid 0x1849 0x244e end - device ref lpc on # LPC bridge + device ref lpc on subsystemid 0x1849 0x1e49 chip superio/nuvoton/nct6776 device pnp 2e.0 off end # Floppy @@ -156,16 +148,14 @@ device pnp 2e.17 on end # GPIOA end end - device ref sata1 on # SATA Controller 1 + device ref sata1 on subsystemid 0x1849 0x1e02 end - device ref smbus on # SMBus + device ref smbus on subsystemid 0x1849 0x1e22 end - device ref sata2 off # SATA Controller 2 - end - device ref thermal off # Thermal - end + device ref sata2 off end + device ref thermal off end end end end