Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62378 )
Change subject: nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code ......................................................................
nb/amd/*/*/northbridge.c: Change the comment 'hole from 0xa0000..' to reflect the code
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I4acc895be00cfdef3ff0eef440f4b85fdb75edf8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62378 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin L Roth martinroth@google.com --- M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/amd/agesa/family15tn/northbridge.c M src/northbridge/amd/agesa/family16kb/northbridge.c M src/northbridge/amd/pi/00730F01/northbridge.c 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved
diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 3507ff7..e102252 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -551,7 +551,7 @@ printk(BIOS_DEBUG, "adsr: basek = %llx, limitk = %llx, sizek = %llx.\n", basek, limitk, sizek);
- /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < 640) && (sizek > 768)) { printk(BIOS_DEBUG,"adsr - 0xa0000 to 0xbffff resource.\n"); ram_resource(dev, (idx | 0), basek, 640 - basek); diff --git a/src/northbridge/amd/agesa/family15tn/northbridge.c b/src/northbridge/amd/agesa/family15tn/northbridge.c index d36c9d4..8c010ee 100644 --- a/src/northbridge/amd/agesa/family15tn/northbridge.c +++ b/src/northbridge/amd/agesa/family15tn/northbridge.c @@ -709,7 +709,7 @@
sizek = limitk - basek;
- /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/agesa/family16kb/northbridge.c b/src/northbridge/amd/agesa/family16kb/northbridge.c index 170a0d2..a343321 100644 --- a/src/northbridge/amd/agesa/family16kb/northbridge.c +++ b/src/northbridge/amd/agesa/family16kb/northbridge.c @@ -721,7 +721,7 @@
sizek = limitk - basek;
- /* see if we need a hole from 0xa0000 to 0xbffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xbffff (768K) */ if ((basek < ((8*64)+(8*16))) && (sizek > ((8*64)+(16*16)))) { ram_resource(dev, (idx | i), basek, ((8*64)+(8*16)) - basek); idx += 0x10; diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index 8a136b6..9889275 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -810,7 +810,7 @@ printk(BIOS_DEBUG, "node %d: basek=%08llx, limitk=%08llx, sizek=%08llx,\n", i, basek, limitk, sizek);
- /* see if we need a hole from 0xa0000 to 0xfffff */ + /* See if we need a hole from 0xa0000 (640K) to 0xfffff (1024K) */ if ((basek < (0xa0000 >> 10) && (sizek > (0x100000 >> 10)))) { ram_resource(dev, (idx | i), basek, (0xa0000 >> 10) - basek); idx += 0x10;