[M] Change in coreboot[master]: mb/siemens/mc_ehl4: Enable SD card - coreboot-gerrit

21 Apr 2023


      Attention is currently required from: Mario Scheithauer, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74653 )
Change subject: mb/siemens/mc_ehl4: Enable SD card
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl4/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74653/comment/25873ee9_c1415017 
PS3, Line 43: 		write16(res2mmio(res, HOSTCTRL2, 0), reg16);
Maybe you can use `clrsetbits32()` and `clrsetbits32()` from `<device/mmio.h>`?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74653
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd9b25301311679cf93b05ba83a24e551261a020
Gerrit-Change-Number: 74653
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Jan Samek jan.samek@siemens.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment