[S] Change in coreboot[main]: payloads/depthcharge: Add default 64-bit libpayload config
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Martin L Roth, Wonkyu Kim.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84107?usp=email )
Change subject: payloads/depthcharge: Add default 64-bit libpayload config ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84107/comment/20fb1a42_de2e01a9?usp... : PS1, Line 11: please state the problem statement clearly here to make the code review easy?
https://review.coreboot.org/c/coreboot/+/84107/comment/787ebdf6_27e84465?usp... : PS1, Line 12: BUG= BUG=none
File payloads/external/depthcharge/Kconfig:
https://review.coreboot.org/c/coreboot/+/84107/comment/f60540ef_44331c02?usp... : PS1, Line 65: LP_DEFCONFIG64_OVERRIDE nit
``` LP_DEFCONFIG_OVERRIDE_x64 ```
https://review.coreboot.org/c/coreboot/+/84107/comment/00db8d1f_ea02c1ab?usp... : PS1, Line 69: The Depthcharge makefile looks for a file config.<boardname> in the : libpayload/configs directory. Say Y here to use the file defconfig : instead. This is can be a convenience for development purposes, or : if the defaults in defconfig are sufficient for your system. this should somehow convey that one needs to select this config to boot a 64-bit payload
Also have a depends on `!LP_DEFCONFIG_OVERRIDE`
File payloads/external/depthcharge/Makefile:
https://review.coreboot.org/c/coreboot/+/84107/comment/268cc413_2ce0d1ea?usp... : PS1, Line 34: defconfig64 use a `_` between defconfig and 64?
File payloads/libpayload/configs/defconfig64:
https://review.coreboot.org/c/coreboot/+/84107/comment/d398779c_972c9d2d?usp... : PS1, Line 3: CONFIG_LP_ARCH_X86_32=n just comment out may be. we don't use `n` to assign to a Kconfig.
``` # CONFIG_LP_ARCH_X86_32 is not set ```
-
Subrata Banik (Code Review)