Attention is currently required from: Martin Roth, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57346 )
Change subject: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
having that overridable might be useful, but that should be done at the fsp driver Kconfig level and […]
Well, if somebody wants to override things from site-local/ or .config,
that should work perfectly fine with the clutter here. It looks like the
author was paid per added line and so they just copied more things as
long as it still built. It actually seems like we could drop everything
below UART_FOR_CONSOLE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23439f3134eef9460625addbff7efd64c5f65ae5
Gerrit-Change-Number: 57346
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 04 Sep 2021 22:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment