Change in coreboot[master]: mb/google/dedede: Request EC to reset AP for a select TPM FW version

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44278 )

Change subject: mb/google/dedede: Request EC to reset AP for a select TPM FW version
......................................................................

mb/google/dedede: Request EC to reset AP for a select TPM FW version

Request EC to reset AP, inside cse_board_reset, when TPM is running FW
version 0.0.22. Otherwise allow the board to fallback to global reset.

BUG=b:162290856
TEST=Ensure that the device boots to OS. Ensure that EC_CMD_AP_RESET is
request when TPM is running FW version 0.0.22 as part of cse_board_reset.
Otherwise global reset is performed.

Change-Id: I95df4411c9edbeb8593822d4e231aa5020491647
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/mainboard/google/dedede/mainboard.c
1 file changed, 10 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/44278/1

diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c
index 1fbdfce..7a860d7 100644
--- a/src/mainboard/google/dedede/mainboard.c
+++ b/src/mainboard/google/dedede/mainboard.c
@@ -4,6 +4,7 @@
 #include <bootstate.h>
 #include <baseboard/variants.h>
 #include <device/device.h>
+#include <drivers/spi/tpm/tpm.h>
 #include <ec/ec.h>
 #include <ec/google/chromeec/ec.h>
 #include <intelblocks/cse.h>
@@ -11,8 +12,15 @@

void cse_board_reset(void)
 {
-	/* TODO: Check tpm firmware version before initiating AP reset. */
-	google_chromeec_ap_reset();
+	struct tpm2_fw_ver reset_fw_ver = {
+		.type = TPM2_FW_VER_TYPE_RW,
+		.epoch = 0,
+		.major_ver = 0,
+		.minor_ver = 22,
+	};
+
+	if (is_tpm2_fw_version(&reset_fw_ver))
+		google_chromeec_ap_reset();
 }

__weak void variant_isst_override(void)

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44278 )

Change subject: mb/google/dedede: Request EC to reset AP for a select TPM FW version
......................................................................

Patch Set 2:

a

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44278 )

Change subject: mb/google/dedede: Request EC to reset AP for a select TPM FW version
......................................................................

Abandoned

Abandoning since the required support is part of CB:44645