Change in coreboot[master]: util/lint/checkpatch.pl: Use "perl_version_ok"

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61466 )

Change subject: util/lint/checkpatch.pl: Use "perl_version_ok"
......................................................................

util/lint/checkpatch.pl: Use "perl_version_ok"

Also use '$minimum_perl_version'.
This is to reduce difference with linux v5.16.

Change-Id: I7c2f5d5c9853dc8ddc8f89a5e2edd6c8613ba790
Signed-off-by: Elyes HAOUAS 
---
M util/lint/checkpatch.pl
1 file changed, 33 insertions(+), 33 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/61466/1

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index 0b8ab79..01e55b5 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -250,11 +250,11 @@

my $exit = 0;

+my $perl_version_ok = 1;
 if ($^V && $^V lt $minimum_perl_version) {
+	$perl_version_ok = 0;
    printf "$P: requires at least perl version %vd\n", $minimum_perl_version;
-	if (!$ignore_perl_version) {
-		exit(1);
-	}
+	exit(1) if (!$ignore_perl_version);
 }

#if no filenames are given, push '-' to read patch from stdin
@@ -1040,11 +1040,11 @@
    hash_show_words(%use_type, "Used");
    hash_show_words(%ignore_type, "Ignored");

-	if ($^V lt 5.10.0) {
+	if (!$perl_version_ok) {
    	print << "EOM"

NOTE: perl $^V is not modern enough to detect all possible issues.
-      An upgrade to at least perl v5.10.0 is suggested.
+      An upgrade to at least perl $minimum_perl_version is suggested.
 EOM
    }
    if ($exit) {
@@ -3112,7 +3112,7 @@
    	}

# check indentation starts on a tab stop
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $sline =~ /^+\t+( +)(?:$c90_Keywords\b|{\s*$|}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=])/) {
    		my $indent = length($1);
    		if ($indent % $tabsize) {
@@ -3125,7 +3125,7 @@
    	}

# check multi-line statement indentation matches previous line
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $prevline =~ /^+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|(\s**\s*$Ident\s*))\s*|(?:*\s*)*$Lval\s*=\s*$Ident\s*)(.*(&&||||,)\s*$/) {
    		$prevline =~ /^+(\t*)(.*)$/;
    		my $oldindent = $1;
@@ -4044,7 +4044,7 @@

# function brace can't be on same line, except for #defines of do while,
 # or if closed on same line
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $sline =~ /$Type\s*$Ident\s*$balanced_parens\s*{/ &&
    	    $sline !~ /#\s*define\b.*do\s*{/ &&
    	    $sline !~ /}/) {
@@ -4657,7 +4657,7 @@
 # check for unnecessary parentheses around comparisons in if uses
 # when !drivers/staging or command-line uses --strict
    	if (($realfile !~ m@^(?:drivers/staging/)@ || $check_orig) &&
-		    $^V && $^V ge 5.10.0 && defined($stat) &&
+		    $perl_version_ok && defined($stat) &&
    	    $stat =~ /(^.\s*if\s*($balanced_parens))/) {
    		my $if_stat = $1;
    		my $test = substr($2, 1, -1);
@@ -4694,7 +4694,7 @@
 # return is not a function
    	if (defined($stat) && $stat =~ /^.\s*return(\s*)(/s) {
    		my $spacing = $1;
-			if ($^V && $^V ge 5.10.0 &&
+			if ($perl_version_ok &&
    		    $stat =~ /^.\s*return\s*($balanced_parens)\s*;\s*$/) {
    			my $value = $1;
    			$value = deparenthesize($value);
@@ -4721,7 +4721,7 @@
                }

# if statements using unnecessary parentheses - ie: if ((foo == bar))
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /\bif\s*((?:(\s*){2,})/) {
    		my $openparens = $1;
    		my $count = $openparens =~ tr@(@(@;
@@ -4738,7 +4738,7 @@
 #	avoid cases like "foo + BAR < baz"
 #	only fix matches surrounded by parentheses to avoid incorrect
 #	conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /^+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) {
    		my $lead = $1;
    		my $const = $2;
@@ -5163,7 +5163,7 @@
 # do {} while (0) macro tests:
 # single-statement macros do not need to be enclosed in do while (0) loop,
 # macro should not end with a semicolon
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $realfile !~ m@/vmlinux.lds.h$@ &&
    	    $line =~ /^.\s*#\s*define\s+$Ident(()?/) {
    		my $ln = $linenr;
@@ -5526,7 +5526,7 @@
    	}

# check for mask then right shift without a parentheses
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /$LvalOrFunc\s*&\s*($LvalOrFunc)\s*>>/ &&
    	    $4 !~ /^&/) { # $LvalOrFunc may be &foo, ignore if so
    		WARN("MASK_THEN_SHIFT",
@@ -5534,7 +5534,7 @@
    	}

# check for pointer comparisons to NULL
-		if ($^V && $^V ge 5.10.0) {
+		if ($perl_version_ok) {
    		while ($line =~ /\b$LvalOrFunc\s*(==|!=)\s*NULL\b/g) {
    			my $val = $1;
    			my $equal = "!";
@@ -5806,7 +5806,7 @@
    	}

# Check for __attribute__ weak, or __weak declarations (may have link issues)
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /(?:$Declare|$DeclareMisordered)\s*$Ident\s*$balanced_parens\s*(?:$Attribute)?\s*;/ &&
    	    ($line =~ /\b__attribute__\s*(\s*(.*\bweak\b/ ||
    	     $line =~ /\b__weak\b/)) {
@@ -5888,7 +5888,7 @@
    	}

# check for vsprintf extension %p<foo> misuses
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+(?![^{]*{\s*).*\b(\w+)\s*(.*$String\s*,/s &&
    	    $1 !~ /^_*volatile_*$/) {
@@ -5935,7 +5935,7 @@
    	}

# Check for misused memsets
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+(?:.*?)\bmemset\s*(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*$FuncArg\s*)/) {

@@ -5953,7 +5953,7 @@
    	}

# Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
-#		if ($^V && $^V ge 5.10.0 &&
+#		if ($perl_version_ok &&
 #		    defined $stat &&
 #		    $stat =~ /^+(?:.*?)\bmemcpy\s*(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*)/) {
 #			if (WARN("PREFER_ETHER_ADDR_COPY",
@@ -5964,7 +5964,7 @@
 #		}

# Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)
-#		if ($^V && $^V ge 5.10.0 &&
+#		if ($perl_version_ok &&
 #		    defined $stat &&
 #		    $stat =~ /^+(?:.*?)\bmemcmp\s*(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*)/) {
 #			WARN("PREFER_ETHER_ADDR_EQUAL",
@@ -5973,7 +5973,7 @@

# check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
 # check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
-#		if ($^V && $^V ge 5.10.0 &&
+#		if ($perl_version_ok &&
 #		    defined $stat &&
 #		    $stat =~ /^+(?:.*?)\bmemset\s*(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*)/) {
 #
@@ -5995,7 +5995,7 @@
 #		}

# typecasts on min/max could be min_t/max_t
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+(?:.*?)\b(min|max)\s*(\s*$FuncArg\s*,\s*$FuncArg\s*)/) {
    		if (defined $2 || defined $7) {
@@ -6019,7 +6019,7 @@
    	}

# check usleep_range arguments
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+(?:.*?)\busleep_range\s*(\s*($FuncArg)\s*,\s*($FuncArg)\s*)/) {
    		my $min = $1;
@@ -6035,7 +6035,7 @@
    	}

# check for naked sscanf
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $line =~ /\bsscanf\b/ &&
    	    ($stat !~ /$Ident\s*=\s*sscanf\s*$balanced_parens/ &&
@@ -6049,7 +6049,7 @@
    	}

# check for simple sscanf that should be kstrto<foo>
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $line =~ /\bsscanf\b/) {
    		my $lc = $stat =~ tr@\n@@;
@@ -6121,7 +6121,7 @@
    	}

# check for function definitions
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^.\s*(?:$Storage\s+)?$Type\s*($Ident)\s*$balanced_parens\s*{/s) {
    		$context_function = $1;
@@ -6161,14 +6161,14 @@

# alloc style
 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /\b($Lval)\s*=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*(\s*(sizeof\s*(\s*struct\s+$Lval\s*))/) {
    		CHK("ALLOC_SIZEOF_STRUCT",
    		    "Prefer $3(sizeof(*$1)...) over $3($4...)\n" . $herecurr);
    	}

# check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+\s*($Lval)\s*=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*(\s*($FuncArg)\s**\s*($FuncArg)\s*,/) {
    		my $oldfunc = $3;
@@ -6197,7 +6197,7 @@
    	}

# check for krealloc arg reuse
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /\b($Lval)\s*=\s*(?:$balanced_parens)?\s*krealloc\s*(\s*\1\s*,/) {
    		WARN("KREALLOC_ARG_REUSE",
    		     "Reusing the krealloc arg is almost always a bug\n" . $herecurr);
@@ -6256,7 +6256,7 @@
    	}

# check for switch/default statements without a break;
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /^+[$;\s]*(?:case[$;\s]+\w+[$;\s]*:[$;\s]*|)*[$;\s]*\bdefault[$;\s]*:[$;\s]*;/g) {
    		my $cnt = statement_rawlines($stat);
@@ -6366,7 +6366,7 @@
    	}

# likely/unlikely comparisons similar to "(likely(foo) > 0)"
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    $line =~ /\b((?:un)?likely)\s*(\s*$FuncArg\s*)\s*$Compare/) {
    		WARN("LIKELY_MISUSE",
    		     "Using $1 should generally have parentheses around the comparison\n" . $herecurr);
@@ -6409,7 +6409,7 @@
 # check for DEVICE_ATTR uses that could be DEVICE_ATTR_<FOO>
 # and whether or not function naming is typical and if
 # DEVICE_ATTR permissions uses are unusual too
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $stat =~ /\bDEVICE_ATTR\s*(\s*(\w+)\s*,\s*(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*)?\s*,\s*(\w+)\s*,\s*(\w+)\s*)/) {
    		my $var = $1;
@@ -6469,7 +6469,7 @@
 #   specific definition of not visible in sysfs.
 # o Ignore proc_create*(...) uses with a decimal 0 permission as that means
 #   use the default permissions
-		if ($^V && $^V ge 5.10.0 &&
+		if ($perl_version_ok &&
    	    defined $stat &&
    	    $line =~ /$mode_perms_search/) {
    		foreach my $entry (@mode_permission_funcs) {