Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35215 )
Change subject: Documentation/coding_style.md: Update line length limit ......................................................................
Documentation/coding_style.md: Update line length limit
Line length limit was bumped to 96 characters, but the coding style did not reflect such a change.
Change-Id: Ifdbb8bc04e49e1fbe9b0c8a642ae814d5a60004a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Documentation/coding_style.md 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/35215/1
diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index 048b8e6..ac0de4e 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -80,11 +80,11 @@ Coding style is all about readability and maintainability using commonly available tools.
-The limit on the length of lines is 80 columns and this is a strongly +The limit on the length of lines is 96 columns and this is a strongly preferred limit.
-Statements longer than 80 columns will be broken into sensible chunks, -unless exceeding 80 columns significantly increases readability and does +Statements longer than 96 columns will be broken into sensible chunks, +unless exceeding 96 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35215 )
Change subject: Documentation/coding_style.md: Update line length limit ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35215 )
Change subject: Documentation/coding_style.md: Update line length limit ......................................................................
Documentation/coding_style.md: Update line length limit
Line length limit was bumped to 96 characters, but the coding style did not reflect such a change.
Change-Id: Ifdbb8bc04e49e1fbe9b0c8a642ae814d5a60004a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35215 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Documentation/coding_style.md 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index 048b8e6..ac0de4e 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -80,11 +80,11 @@ Coding style is all about readability and maintainability using commonly available tools.
-The limit on the length of lines is 80 columns and this is a strongly +The limit on the length of lines is 96 columns and this is a strongly preferred limit.
-Statements longer than 80 columns will be broken into sensible chunks, -unless exceeding 80 columns significantly increases readability and does +Statements longer than 96 columns will be broken into sensible chunks, +unless exceeding 96 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)