Attention is currently required from: Paul Menzel, Stefan Reinauer.
Petr Cvek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65809?usp=email )
Change subject: drivers/pc80/pc/i8254.c: Initialize timer 1 in mode 2 ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Petr, how did you test this patch?
It is just the configuration matching the documentation. Originally I've stumbled upon timer1 because it wasn't enabled in SeaBIOS and it caused Windows 98SE instalation CD to hang (ASPI2DOS.SYS and KEYB.COM depends on correctly working timer1 to be used as a delay loop). Setting it up as described in the datasheet causes win98se to correctly proceed. I don't remember if mode 3 actually worked too, it seems it should on i8254 but intel datasheet forbids it on ICH7. So my idea was to match the safest settings.
-
Petr Cvek (Code Review)