Attention is currently required from: Angel Pons, Jérémy Compostella, Nico Huber.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84040?usp=email )
Change subject: ext_stage_cache: Make sure variables are initialized
......................................................................
Patch Set 7:
(1 comment)
File src/lib/ext_stage_cache.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/70551cdb_6219e5bf?usp... :
PS7, Line 18: stage_cache_external_region(&base, &size);
: if (base == NULL || size == 0)
: return;
Would it make sense to return status from `stage_cache_external_region()`? […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84040?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1851295646258e97c489dc7402b9df3fcf092c1
Gerrit-Change-Number: 84040
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 00:14:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz