Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )
Change subject: soc/intel/braswell/southcluster.c: Correct serial IRQ support ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/29398/10/src/mainboard/google/cyan/variants/... File src/mainboard/google/cyan/variants/banon/devicetree.cb:
https://review.coreboot.org/#/c/29398/10/src/mainboard/google/cyan/variants/... PS10, Line 98: register "serirq_mode" = "SERIRQ_QUIET" `SERIRQ_QUIET` is the default (0 case in `enum serirq_mode`), so we don't have to clutter all devicetrees.
https://review.coreboot.org/#/c/29398/10/src/soc/intel/braswell/southcluster... File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29398/10/src/soc/intel/braswell/southcluster... PS10, Line 304: sc_enable_serial_irqs(dev); Why enable continuous mode first and then change the mode later? Can't we just set the final mode here?