Attention is currently required from: Elyes Haouas, Martin L Roth.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email )
Change subject: tree: Use pkgconf over pkg-config
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83157/comment/3c7618d8_3eb7ff6f?usp... :
PS5, Line 7: tree: Use pkgconf over pkg-config
Is there any justification for this patch?
From a quick 1 minute Google search on the topic it sounds like pkgconf has a backwards-compatible mode when called as pkg-config. So unless we really need any new feature from it (do we?), shouldn't we stick with the older, more widely compatible name?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83157?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8
Gerrit-Change-Number: 83157
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 25 Jun 2024 22:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No