Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56789 )
Change subject: libpayload/pci: Add support for bus mapping
......................................................................
Patch Set 53:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56789/comment/c473ea48_ef79f83b
PS2, Line 7: Split PCI interfaces as common and chip related
Shelly, could you take over to review this? […]
I think that it's fine to have the different definitions for the pci_*config* functions structured like this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74801bd4f3de51cbb574e86cd9bb09931152554
Gerrit-Change-Number: 56789
Gerrit-PatchSet: 53
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Thu, 07 Apr 2022 01:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan.m.shaikh@gmail.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-MessageType: comment