Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Paul Menzel.
V Sowmya has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email )
Change subject: mb/google/brya: Create tereid variant ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83145/comment/e9c7bca5_2d817df9?usp... : PS1, Line 7: a
Remove.
Done
https://review.coreboot.org/c/coreboot/+/83145/comment/2487c14c_a442a6b0?usp... : PS1, Line 9: Twinlake
Twin Lake
Done
https://review.coreboot.org/c/coreboot/+/83145/comment/9629acb6_dec5a868?usp... : PS1, Line 11: Twinlake
Twin Lake
Done
https://review.coreboot.org/c/coreboot/+/83145/comment/1146c065_7b90d524?usp... : PS1, Line 9: This patch creates a new tereid variant, which is a Twinlake : platform. This variant uses Nivviks board mounted with the : Twinlake SOC and hence the plan is to reuse the existing : nivviks variant code.
Please use 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/83145/comment/1422b89b_f4353132?usp... : PS1, Line 15: Genearte
Generate
Done
https://review.coreboot.org/c/coreboot/+/83145/comment/23edcbce_638e89da?usp... : PS1, Line 15: TEST= Genearte
Please remove the space after =.
Done