Marco Chen has posted comments on this change. ( https://review.coreboot.org/25587 )
Change subject: mb/google/fizz: Add device index for 2nd LAN ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25587/1/src/mainboard/google/fizz/devicetree... File src/mainboard/google/fizz/devicetree.cb:
https://review.coreboot.org/#/c/25587/1/src/mainboard/google/fizz/devicetree... PS1, Line 376: register "device_index" = "1" For multiple LAN interfaces, as I know we should set device_index from 1 to 10. In case of Fizz, we should set these two interfaces's device_index to 1 and 2 so VPDs would be ethernet_mac0 and ethernet_mac1.
Therefore line 354 should have device_index as 1 and here be 2?