[XS] Change in coreboot[main]: include/stdbool: Don't unconditionally typedef bool - coreboot-gerrit

11 Sep 2024


      Attention is currently required from: Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83909?usp=email )
Change subject: include/stdbool: Don't unconditionally typedef bool
......................................................................
Patch Set 7:
(1 comment)
File src/include/stdbool.h:
https://review.coreboot.org/c/coreboot/+/83909/comment/278446d5_107a938c?usp... :
PS7, Line 7: #ifndef bool
...
Why is this needed? Is there an issue with newer toolchains without C23?
If I remember well, OpenSBI unconditionally typedef bool and I found it somehow stupid (3rdparty/opensbi/include/sbi/sbi_types.h).
I prefer to avoid doing the same thing.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea
Gerrit-Change-Number: 83909
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 11 Sep 2024 02:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de