Attention is currently required from: Arthur Heymans, Paul Menzel, Subrata Banik, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )
Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config ......................................................................
Patch Set 9:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/75756/comment/75476bf9_58de5988 : PS9, Line 226: /* skip old type for save static memory : "Other", : "Unknown", : "DRAM", : "EDRAM", : "VRAM", : "SRAM", : "RAM", : "ROM", : "Flash", : "EEPROM", : "FEPROM", : "EPROM", : "CDRAM", : "3DRAM", : "SDRAM", : "SGRAM", : "RDRAM", : "DDR", : "DDR2", : "DDR2 FB-DIMM", : "Reserved", : "Reserved", : "Reserved", : "DDR3", : "FBD2", : */
Is printing SMBIOS information for older DRAM specs not desirable? It will print unsupported type, […]
oh because I think we don't need it. Since it's too old. dmicode is an exe file so it can put a lot static data. Do we want to? I am okay with that.
https://review.coreboot.org/c/coreboot/+/75756/comment/50917e57_2c503a57 : PS9, Line 265: 0x1A
do we have any existing macro for DDR4 (somewhere in the code)?
oh yes. MEMORY_TYPE_DDR4