Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/13410 )
Change subject: lenovo/x60: Enable TPM
......................................................................
Patch Set 9:
(2 comments)
Thank you for the review.
I'm preparing Linux 4.9 to check if the behavior has not been changed from the original before revising the commit message, since recent kernels do not detect the device even with force=1 as mentioned above.
https://review.coreboot.org/c/coreboot/+/13410/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/13410/9//COMMIT_MSG@7
PS9, Line 7: lenovo/x60
nit: mb/lenovo/x60
Ack
https://review.coreboot.org/c/coreboot/+/13410/9//COMMIT_MSG@14
PS9, Line 14: 3d02b9c
If you write "commit 3d02b9c" in a single line, Gerrit will mark it as a link.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/13410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e65b37507c111af1c0c56822327d5497f58f085
Gerrit-Change-Number: 13410
Gerrit-PatchSet: 9
Gerrit-Owner: Denis Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Masanori Ogino
mogino@acm.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Sep 2020 03:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment