Attention is currently required from: Reka Norman, Kangheui Won, Paul Menzel, Rizwan Qureshi, Patrick Rudolph.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61126 )
Change subject: soc/intel/alderlake: Add eMMC PCR Port ID for Alder Lake N
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/alderlake/include/soc/pcr_ids.h:
https://review.coreboot.org/c/coreboot/+/61126/comment/b56676b3_34dac9b8
PS2, Line 37: #define PID_EMMC 0xa1
Please mention the source, like datasheet name and revision, in the commit message, where this is de […]
Done
File src/soc/intel/alderlake/include/soc/pcr_ids.h:
https://review.coreboot.org/c/coreboot/+/61126/comment/7f23fc39_8b33892e
PS1, Line 37:
use space instead of a tab
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dc494d1748e66b8b4058954f127ec226863e8af
Gerrit-Change-Number: 61126
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 Jan 2022 15:06:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment