Attention is currently required from: Tarun Tuli, Dinesh Gehlot, Paul Menzel.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/: Implement an API to get ISH version ......................................................................
Patch Set 9:
(3 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74209/comment/252a61b4_41aa42c0 PS9, Line 1277: /* : * Initialize the CSE device with provided temporary BAR. If BAR is 0 use a : * default. This is intended for pre-mem usage only where BARs haven't been : * assigned yet and devices are not enabled. May I know how this comment is connected with get_ish_version()?
https://review.coreboot.org/c/coreboot/+/74209/comment/7e28ada3_0461c93d PS9, Line 1282: bool please prefer enum cb_err.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/74209/comment/256291ea_c4788da1 PS9, Line 453: bool please prefer enum cb_err.