Attention is currently required from: Raul Rangel. Martin Roth - Personal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60831 )
Change subject: util/scripts: Add options to update_submodules ......................................................................
Patch Set 1:
(8 comments)
File util/scripts/update_submodules:
https://review.coreboot.org/c/coreboot/+/60831/comment/2cb75136_0e42d3b7 PS1, Line 21: submodule_dir
I would add the s back since it's a list. […]
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/e933b978_7f6f78ec PS1, Line 21: submodule_dir
I would add the s back since it's a list. […]
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/60b701d2_c9ea1eaa PS1, Line 21: git submodule foreach pwd
Sounds good.
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/618564b4_e949025e PS1, Line 75: shift
Thanks. I'll do that.
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/772dc2b3_b622bb06 PS1, Line 96: cd
I just saw the `cd $TOP` below. I'm fine either way.
Leaving it the way it is.
https://review.coreboot.org/c/coreboot/+/60831/comment/2f4b3b7c_6ee1567a PS1, Line 107: --git-dir="${submodule}/.git"
Good call, i don't think it should be needed here. […]
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/658a0a77_0dd71a79 PS1, Line 131: git checkou
Sounds good.
Done
https://review.coreboot.org/c/coreboot/+/60831/comment/ac2628a7_969e024f PS1, Line 133: sleep 1
For some reason it caused issues with the following commands if I didn't have the sleeps in there. […]
Removed.