Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47280 )
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
mb/google/puff/var/dooly: Add WEIDA touchscreen device
Adds ACPI properties for WDT8762A device.
Per spec v0.8 HID name WDHT2002 T14=100ms
BUG=b:163561649 BRANCH=puff TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Change-Id: I178e9d5aa1e1501d33b3cd4092f3f522bb6f1a74 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47280/1
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index ee91dd3..de6dfcd 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -311,7 +311,20 @@ end # I2C #0 ALC1015 device pci 15.1 off end # I2C #1 device pci 15.2 on end # I2C #2 LVDS - device pci 15.3 on end # I2C #3 Touchscreen + device pci 15.3 on + chip drivers/i2c/hid + register "generic.hid" = ""WDHT2002"" + register "generic.desc" = ""WDT Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A20_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "100" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C #3 Touchscreen device pci 16.0 on end # Management Engine Interface 1 device pci 19.0 on chip drivers/i2c/generic
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47280
to look at the new patch set (#2).
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
mb/google/puff/var/dooly: Add WEIDA touchscreen device
Adds ACPI properties for WDT8762A device.
Per spec v0.8 HID name WDHT2002 T14=100ms
BUG=b:163561649 BRANCH=puff TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Change-Id: I178e9d5aa1e1501d33b3cd4092f3f522bb6f1a74 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47280/2
Hello Sam McNally, build bot (Jenkins), Edward O'Callaghan, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47280
to look at the new patch set (#3).
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
mb/google/puff/var/dooly: Add WEIDA touchscreen device
Adds ACPI properties for WDT8762A device.
Per spec v0.8 HID name WDHT2002 T14=100ms
BUG=b:163561649 BRANCH=puff TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Change-Id: I178e9d5aa1e1501d33b3cd4092f3f522bb6f1a74 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/47280/3
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47280 )
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
Patch Set 3:
Please help review +2 or give comment. Thanks
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47280 )
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
Patch Set 3: Code-Review+2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47280 )
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
Patch Set 3: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47280 )
Change subject: mb/google/puff/var/dooly: Add WEIDA touchscreen device ......................................................................
mb/google/puff/var/dooly: Add WEIDA touchscreen device
Adds ACPI properties for WDT8762A device.
Per spec v0.8 HID name WDHT2002 T14=100ms
BUG=b:163561649 BRANCH=puff TEST=emerge-puff coreboot and check system dmesg and evtest can get device.
Change-Id: I178e9d5aa1e1501d33b3cd4092f3f522bb6f1a74 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47280 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/dooly/overridetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/dooly/overridetree.cb b/src/mainboard/google/hatch/variants/dooly/overridetree.cb index f4b6d63..8ced613 100644 --- a/src/mainboard/google/hatch/variants/dooly/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dooly/overridetree.cb @@ -311,7 +311,20 @@ end # I2C #0 ALC1015 device pci 15.1 off end # I2C #1 device pci 15.2 on end # I2C #2 LVDS - device pci 15.3 on end # I2C #3 Touchscreen + device pci 15.3 on + chip drivers/i2c/hid + register "generic.hid" = ""WDHT2002"" + register "generic.desc" = ""WDT Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A20_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "100" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C #3 Touchscreen device pci 16.0 on end # Management Engine Interface 1 device pci 19.0 on chip drivers/i2c/generic
-
Edward O'Callaghan (Code Review) -
Sam McNally (Code Review)
-
Tony Huang (Code Review)