Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56679 )
Change subject: mb/google/brya: Ensure descriptor is writable before writing
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/bootblock.c:
https://review.coreboot.org/c/coreboot/+/56679/comment/207595db_8afa3014
PS1, Line 107: configure_descriptor
I am thinking rather than always performing this on all brya variants by default, we should allow variant to decide if it wants to do this. This will ensure that the override logic does not slip into shipping devices. What do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56679
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09613d569ffc92fc3b7334bc30628c4f88955250
Gerrit-Change-Number: 56679
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 11 Aug 2021 03:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment