Change in coreboot[master]: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field and max memory spe...

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45797 )

Change subject: vc/intel/fsp/fsp2_0/cpx_sp: Add DIMM present field and max memory speed function
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45797/4/src/vendorcode/intel/fsp/fs... 
File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/memory.h:

https://review.coreboot.org/c/coreboot/+/45797/4/src/vendorcode/intel/fsp/fs... 
PS4, Line 47: uint16_t get_max_memory_speed(uint32_t commonTck)
> Why is this defined inside the header?

It is a simple function, so it is defined inside a header file.