Attention is currently required from: Jason Nien, Kangheui Won, Isaac Lee, Jon Murphy, Martin Roth, Karthik Ramasubramanian.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68482 )
Change subject: mb/google/skyrim/var/frostflow: Update devicetree setting
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Hi Matt,
Could you check Karthik's comment?
Thank you.
File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68482/comment/3c1a1293_11a4ff7c
PS3, Line 111: GPIO_24
I think the GPIO config in variants/baseboard/gpio. […]
Based on the comment, I created the another CL to update the IRQ setting in baseboard/gpio.c.
Thank you.
Here is the CL:
https://review.coreboot.org/c/coreboot/+/68638
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68482
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia03962b0e01394ddcd4971cbe0172ef5bd913e15
Gerrit-Change-Number: 68482
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 21 Oct 2022 02:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment