[S] Change in coreboot[master]: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable devicetree ...

[Felix Singer (Code Review)]

Attention is currently required from: Arthur Heymans, Elyes Haouas, Eric Lai, Jan Samek, Mario Scheithauer, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Subrata Banik.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75871?usp=email )

Change subject: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable devicetree option
......................................................................

Patch Set 4:

(2 comments)

Patchset:

PS3:
> It would allow to use more natural language. To me, neither `_enabled = 1` nor […]

I like the idea, though it feels like overengineering. I wouldn't like to invent a new keyword just because it sounds more natural. This would apply to many things. I guess it would be even more confusing.. When should people use true/false and when enable/disable?

Using true/false this way is totally fine for me
```
register s0ix = true
```

File src/soc/intel/skylake/chip.h:

https://review.coreboot.org/c/coreboot/+/75871/comment/1de03e70_7a6b2b38 :
PS4, Line 15: #include <stdbool.h>
            : #include <stdint.h>
> Shouldn't we leave this decision to the author? […]

could be cleaned up in a separate step.