Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35433 )
Change subject: superio/common: Fix types in printf ......................................................................
superio/common: Fix types in printf
Found by Coverity Scan #1405310
Change-Id: I53146e7fc402500effc63ce276ecfce4d72a4f7f Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/superio/common/ssdt.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/35433/1
diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index 035f06a..a919aa5 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -127,11 +127,11 @@ if (!res || !res->base || !res->size) continue;
- snprintf(name, sizeof(name), "IO%XB", i); + snprintf(name, sizeof(name), "IO%zXB", i); name[4] = '\0'; acpigen_write_name_integer(name, res->base);
- snprintf(name, sizeof(name), "IO%XS", i); + snprintf(name, sizeof(name), "IO%zXS", i); name[4] = '\0'; acpigen_write_name_integer(name, res->size); }
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35433 )
Change subject: superio/common: Fix types in printf ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35433 )
Change subject: superio/common: Fix types in printf ......................................................................
superio/common: Fix types in printf
Found by Coverity Scan #1405310
Change-Id: I53146e7fc402500effc63ce276ecfce4d72a4f7f Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35433 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/common/ssdt.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index 035f06a..a919aa5 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -127,11 +127,11 @@ if (!res || !res->base || !res->size) continue;
- snprintf(name, sizeof(name), "IO%XB", i); + snprintf(name, sizeof(name), "IO%zXB", i); name[4] = '\0'; acpigen_write_name_integer(name, res->base);
- snprintf(name, sizeof(name), "IO%XS", i); + snprintf(name, sizeof(name), "IO%zXS", i); name[4] = '\0'; acpigen_write_name_integer(name, res->size); }