[XS] Change in coreboot[main]: util/ifdtool: Exit with failure on unrecognized flags

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84260?usp=email )

Change subject: util/ifdtool: Exit with failure on unrecognized flags
......................................................................

util/ifdtool: Exit with failure on unrecognized flags

ifdtool will exit with success while encountering an unrecognized flag.
For example, -g is a newly introduced flag, when we want to call it with
an older version of ifdtool, we will get the return value 0 and cause
confusion.

This patch change the exit status for unrecognized flags and doesn't
change the exit status for -h and -?.

BUG=b:362983041
BRANCH=none
TEST=futility update --servo --image /var/tmp/image.bin --quirks
     unlock_csme on the servo host with old ifdtool

Signed-off-by: Hsuan Ting Chen 
Change-Id: I046ad7ec790cda41a98a1de5cd730d32f65a9067
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84260
Tested-by: build bot (Jenkins) 
Reviewed-by: Subrata Banik 
---
M util/ifdtool/ifdtool.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Subrata Banik: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 32b2081..5993bfc 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -2514,10 +2514,13 @@
    		break;
    	case 'h':
    	case '?':
-		default:
    		print_usage(argv[0]);
    		exit(EXIT_SUCCESS);
    		break;
+		default:
+			print_usage(argv[0]);
+			exit(EXIT_FAILURE);
+			break;
    	}
    }