Attention is currently required from: Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 )
Change subject: soc/mediatek/mt8192: initialize DFD ......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/56797/comment/66a83d42_40cae3a1 PS4, Line 70: This option enables DFD (Design for Debug) settings. Please extend the description in a followup.
File src/soc/mediatek/mt8192/dfd.c:
https://review.coreboot.org/c/coreboot/+/56797/comment/55899d2d_fb6a3888 PS4, Line 9: printk(BIOS_INFO, "[%s]\n", __func__); This reads like a debug message.
File src/soc/mediatek/mt8192/include/soc/dfd.h:
https://review.coreboot.org/c/coreboot/+/56797/comment/87482154_381fa153 PS4, Line 6: #define CPC_FLOW_CTRL_CFG 0x0C53A814 : #define RESET_ON_KEEP_EN BIT(17) : : /* DFD dump address and size need to be the same as defined in Kernel DTS. */ : #define DFD_DUMP_ADDRESS 0x6A000000 : #define DFD_DUMP_SIZE (1 * MiB) Where are these – besides `RESET_ON_KEEP_EN` – used?