Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71869 )
Change subject: drivers/intel/i210.h: Remove 'extern' from declaration ......................................................................
drivers/intel/i210.h: Remove 'extern' from declaration
"extern" is always implied with function declarations. Also remove the comment as the linker will just tell you the same if a definition is missing.
Change-Id: I53679ab57981790f82affb46a006281b348af574 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/71869 Reviewed-by: Paul Menzel paulepanter@mailbox.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/drivers/intel/i210/i210.h 1 file changed, 19 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/drivers/intel/i210/i210.h b/src/drivers/intel/i210/i210.h index 1cc6a28..baaab6e 100644 --- a/src/drivers/intel/i210/i210.h +++ b/src/drivers/intel/i210/i210.h @@ -30,7 +30,6 @@ #define MAC_ADDR_LEN 6
/* We need one function we can call to get a MAC address to use */ -/* This function can be coded somewhere else but must exist. */ -extern enum cb_err mainboard_get_mac_address(struct device *dev, uint8_t mac[MAC_ADDR_LEN]); +enum cb_err mainboard_get_mac_address(struct device *dev, uint8_t mac[MAC_ADDR_LEN]);
#endif /* _INTEL_I210_H_ */