Change in coreboot[master]: amdfwtool: Add a flag to record the second gen instead of romsig - coreboot-gerrit

6 Apr 2022


      Attention is currently required from: Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63344 )
Change subject: amdfwtool: Add a flag to record the second gen instead of romsig
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/63344/comment/6930eecc_d7c6c472 
PS3, Line 1387: 	if (cb_config->second_gen) {
...
i think this has the logic backwards since EFS_SECOND_GEN is defined as 0. […]
Done.
A stupid mistake.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63344
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id50311034b46aa1791dcc10b107de4af6c86b927
Gerrit-Change-Number: 63344
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 06 Apr 2022 02:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment