Change in coreboot[master]: soc/intel/skylake: Move pci_irqs.asl from SA to PCH as applicable
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38510 )
Change subject: soc/intel/skylake: Move pci_irqs.asl from SA to PCH as applicable ......................................................................
soc/intel/skylake: Move pci_irqs.asl from SA to PCH as applicable
TEST=Build and boot EVE and Soraka to OS.
Change-Id: If95101193fa1b528dc64f57c0fc12f13f16d82b4 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/skylake/acpi/pch.asl M src/soc/intel/skylake/acpi/systemagent.asl 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38510/1
diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index 0aba2e7..ce1619a 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -23,6 +23,9 @@ #include <soc/gpe.h> #include <soc/pcr_ids.h>
+/* PCI IRQ assignment */ +#include "pci_irqs.asl" + /* GPIO Controller */ #include "gpio.asl"
diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 89380aa..0857495 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -336,6 +336,3 @@ Return (BUF0) } } - -/* PCI IRQ assignment */ -#include "pci_irqs.asl"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38510 )
Change subject: soc/intel/skylake: Move pci_irqs.asl from SA to PCH as applicable ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38510/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38510/2//COMMIT_MSG@7 PS2, Line 7: as applicable I would omit the last two words to make the commit summary shorter. If you want, you can add a reason below, e.g.:
The hardware that handles PCI IRQs is in the PCH.
Hello Patrick Rudolph, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38510
to look at the new patch set (#3).
Change subject: soc/intel/skylake: Move pci_irqs.asl from SA to PCH ......................................................................
soc/intel/skylake: Move pci_irqs.asl from SA to PCH
SoC handles PCI IRQs programming inside PCH related ASL.
TEST=Build and boot EVE and Soraka to OS.
Change-Id: If95101193fa1b528dc64f57c0fc12f13f16d82b4 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/skylake/acpi/pch.asl M src/soc/intel/skylake/acpi/systemagent.asl 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/38510/3
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38510 )
Change subject: soc/intel/skylake: Move pci_irqs.asl from SA to PCH ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38510/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38510/2//COMMIT_MSG@7 PS2, Line 7: as applicable
I would omit the last two words to make the commit summary shorter. […]
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38510 )
Change subject: soc/intel/skylake: Move pci_irqs.asl from SA to PCH ......................................................................
soc/intel/skylake: Move pci_irqs.asl from SA to PCH
SoC handles PCI IRQs programming inside PCH related ASL.
TEST=Build and boot EVE and Soraka to OS.
Change-Id: If95101193fa1b528dc64f57c0fc12f13f16d82b4 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38510 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/skylake/acpi/pch.asl M src/soc/intel/skylake/acpi/systemagent.asl 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/skylake/acpi/pch.asl b/src/soc/intel/skylake/acpi/pch.asl index 0aba2e7..ce1619a 100644 --- a/src/soc/intel/skylake/acpi/pch.asl +++ b/src/soc/intel/skylake/acpi/pch.asl @@ -23,6 +23,9 @@ #include <soc/gpe.h> #include <soc/pcr_ids.h>
+/* PCI IRQ assignment */ +#include "pci_irqs.asl" + /* GPIO Controller */ #include "gpio.asl"
diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 89380aa..0857495 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -336,6 +336,3 @@ Return (BUF0) } } - -/* PCI IRQ assignment */ -#include "pci_irqs.asl"
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)