Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55142 )
Change subject: FSP2.0 platforms: Use bootloader reserved memory for BERT ......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/55142/comment/d3e67e71_6b24a0e3 PS3, Line 40: * +---------------------------+ TOLUM / top_of_ram / cbmem_top update comment
https://review.coreboot.org/c/coreboot/+/55142/comment/443c73d0_e234563b PS3, Line 61: *start = cbmem_top(); : *size = CONFIG_ACPI_BERT_SIZE; Just wondering: this ends up being UC instead of WB: see systemagent.c 'top_of_ram -> TOLUD'. Should marking things in that region as UC be reconsidered given that it's often just DRAM, even though for special purposes. It could improve the final MTRR solution.
-
Arthur Heymans (Code Review)